Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export wallets always export default path (ignore path parameter) #79

Closed
saman-hosseini opened this issue Mar 26, 2023 · 0 comments
Closed

Comments

@saman-hosseini
Copy link

I found a problem in "exportWallets" method. the method has 3 parameters but the second parameter (_path1) never used.
on the other hand when it called from index.ts, just two parameter passed to it, so the third parameter will be "null" all the time and the default path will be export all the time.
https://github.com/tatumio/tatum-kms/blob/388096517464d9dedc9aa8285b3724fae02a2ddc/src/index.ts#L145
https://github.com/tatumio/tatum-kms/blob/388096517464d9dedc9aa8285b3724fae02a2ddc/src/management.ts#L81

saman-hosseini added a commit to saman-hosseini/tatum-kms that referenced this issue Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants