Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the deep link plugin support custom schemes on android? #1313

Open
ii41 opened this issue May 13, 2024 · 2 comments
Open

Does the deep link plugin support custom schemes on android? #1313

ii41 opened this issue May 13, 2024 · 2 comments
Labels
enhancement New feature or request platform: android Android specific issues platform: ios iOS specific issues plugin: deep-link

Comments

@ii41
Copy link

ii41 commented May 13, 2024

Reading the official Android deep link documentation, they appear to support custom deep link schemes. The HTTP/HTTPS schemes are actually called web links instead. With non-HTTP/HTTPS deep link schemes no internet connection or verification is needed. Reading the README of the deep link plugin, it seems that at this moment it only supports custom schemes on desktop.

@ii41
Copy link
Author

ii41 commented May 13, 2024

I went to check the code, the android scheme is hardcoded to be http/https:

<data android:scheme="http" />
<data android:scheme="https" />

Additionally, it's hardcoded that the platform will always verify the host: an intent filter marked with android.intent.category.BROWSABLE will require Android to verify host when the scheme is http/https, and here the intent filter is indeed marked with it.

This isn't very friendly to developers...

@ii41
Copy link
Author

ii41 commented May 13, 2024

I'll see if I can make a PR. I've never written code for a plugin though.

@FabianLars FabianLars added enhancement New feature or request platform: android Android specific issues plugin: deep-link platform: ios iOS specific issues labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request platform: android Android specific issues platform: ios iOS specific issues plugin: deep-link
Projects
None yet
Development

No branches or pull requests

2 participants