Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shell] Add option to spawn command in process group #1332

Open
FabianLars opened this issue May 16, 2024 · 0 comments
Open

[shell] Add option to spawn command in process group #1332

FabianLars opened this issue May 16, 2024 · 0 comments
Labels
enhancement New feature or request plugin: shell

Comments

@FabianLars
Copy link
Member

this is basically the fix to issues like pyinstaller apps not being killed because pyinstaller wraps the actual app in a thin parent process that doesn't clean up after itself.

v1's command code was a bit too much for me to find motivation tbh but in this plugin it should be fairly straight forward.

Since may be use cases where this is not desirable, it will be a simple boolean option.

The implementation should use https://github.com/watchexec/process-wrap, the successor of command-group.

p.s. just opening this issue so i don't forget about it until next week, not asking the team to work on this (however, if a community member wants to work on this then i'd be quite happy about it)

@FabianLars FabianLars added enhancement New feature or request plugin: shell labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin: shell
Projects
None yet
Development

No branches or pull requests

1 participant