Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename kill-children.sh to tauri-stop-dev-processes.sh #9669

Merged
merged 1 commit into from May 7, 2024

Conversation

FabianLars
Copy link
Member

closes #9665

Removing the file after each use imo doesn't make sense, so at least make it obvious that the file belongs to tauri.

i feel like "kill" was more correct than "stop" but whatever.

@FabianLars FabianLars requested a review from a team as a code owner May 6, 2024 09:42
@amrbashir amrbashir merged commit d2fc48f into dev May 7, 2024
11 checks passed
@amrbashir amrbashir deleted the fix/rename-kill-children-script branch May 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Do you plan on not leaving a kill-children.sh script in our /tmp?
2 participants