Correct Nixery comparison with nixery-layers blog post #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tazjin
reviewed
Sep 11, 2023
| Nix-based images. It has an [improved layering design][nixery-layers] compared | ||
| to upstream `pkgs.dockerTools.buildImage` but is still fundamentally a | ||
| heuristics- based layering strategy (see above), so it still suffers from the | ||
| same inefficiency in duplication. However, Nixery can totally start building |
There was a problem hiding this comment.
Maybe link to the Github issue where we're discussing this, so that people who come across it can follow the progress!
There was a problem hiding this comment.
Done here: 194b1c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: tazjin/nixery#160