Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter binding lists should force parameters bindings to be enumerated in source order. #30

Open
efaust opened this issue Apr 12, 2018 · 4 comments

Comments

@efaust
Copy link

efaust commented Apr 12, 2018

Right now the reference encoder feels free to sort parameter bindings lexicographically, which doesn't play nicely with engines.

@Yoric
Copy link
Collaborator

Yoric commented Apr 12, 2018

What's the problem, exactly? Default arguments?

@Yoric
Copy link
Collaborator

Yoric commented Apr 24, 2018

@efaust Is this still a problem? Do you want me to do something about this?

@arai-a
Copy link

arai-a commented Jul 27, 2018

CheckParameterNames checks the order in step 5:
https://binast.github.io/ecmascript-binary-ast/#sec-checkparameternames

and actualParams has names in the syntactical order:
https://tc39.github.io/ecma262/#sec-function-definitions-static-semantics-boundnames

so, if the order doesn't match, it's the reference encoder's bug.
I'll check it shortly

@arai-a
Copy link

arai-a commented Jul 31, 2018

moved the issue to binjs-ref.
I'd suggest closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants