Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the spec draft, missing exposing of Symbol.{ dispose, asyncDispose } #185

Open
zloirock opened this issue Jul 7, 2023 · 6 comments
Open
Labels
bug Something isn't working normative Indicates a normative change to the specification

Comments

@zloirock
Copy link
Contributor

zloirock commented Jul 7, 2023

Like here:

image

That causes such issues: nodejs/node#48699

@ljharb
Copy link
Member

ljharb commented Jul 7, 2023

I don't think this is the cause of node having the wrong descriptors here, to be fair, but it's certainly an omission.

@zloirock
Copy link
Contributor Author

zloirock commented Jul 7, 2023

The current spec has nothing about the descriptors of those symbols (but it should be for consistency with all the rest), so it seems it's the cause of this issue.

@ljharb
Copy link
Member

ljharb commented Jul 7, 2023

The original implementer in node wasn't looking at the spec either way, they were just adding the Symbols.

@zloirock
Copy link
Contributor Author

zloirock commented Jul 7, 2023

As an option.

@rbuckton
Copy link
Collaborator

I can add these to the proposal spec, though the intent was to emulate the exact same behavior we specify for every other built-in symbol on Symbol.

@rbuckton rbuckton added bug Something isn't working normative Indicates a normative change to the specification labels Jul 13, 2023
@napsta32
Copy link

Maybe this is related to typechecking the Playwright project by using tsc --noEmit. I get a bunch of errors:

node_modules/playwright-core/types/types.d.ts:16639:11 - error TS2339: Property 'asyncDispose' does not exist on type 'SymbolConstructor'.

16639   [Symbol.asyncDispose](): Promise<void>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working normative Indicates a normative change to the specification
Projects
None yet
Development

No branches or pull requests

4 participants