Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity cover grammar #224

Open
waldemarhorwat opened this issue Apr 9, 2024 · 1 comment
Open

Identity cover grammar #224

waldemarhorwat opened this issue Apr 9, 2024 · 1 comment

Comments

@waldemarhorwat
Copy link

The CoverAwaitExpressionAndAwaitUsingDeclarationHead and AwaitExpression grammars are identical, so I'm curious about the editorial decision to reparse in that case.

The proposal includes instances of static semantics reparsing a CoverAwaitExpressionAndAwaitUsingDeclarationHead as an AwaitExpression, and generating an error if that fails, but it can't fail.

I assume the reason to keep the cover conceptually separate from the identical covered grammar is so that assertions like that in AwaitExpression work cleanly; if so, an informative note might be in order.
@rbuckton
Copy link
Collaborator

rbuckton commented Apr 9, 2024

@syg, @michaelficarra, @bakkot do you have thoughts on this? Is it worth leaving the cover in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbuckton @waldemarhorwat