Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should npm publish validate sourcemaps of public packages? #45

Open
justingrant opened this issue May 18, 2023 · 1 comment
Open

Should npm publish validate sourcemaps of public packages? #45

justingrant opened this issue May 18, 2023 · 1 comment

Comments

@justingrant
Copy link

A problem today is that many packages ship with broken sourcemaps (e.g. sources point to files that don't exist in the package tgz) but nothing in the publishing workflow alerts maintainers that something is wrong.

It would be nice if npm publish for public packages failed by default if the sourcemap is broken.
@justingrant justingrant changed the title Should npm publish of public packages validate sourcemaps? Should npm publish validate sourcemaps of public packages? May 18, 2023
@kamilogorek
Copy link
Member

In the ideal world it would be great to have that, however I'm not sure how feasible this is with the current state of ecosystem. Although, nothing stops us from aiming high :)
A nice middle-ground for now would be to create a cli, based on #15 that could be used as a part of npm prepublish step, which could in the future become a built-in feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justingrant @kamilogorek