Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] sift-cli installer broken due to python dependency changes #579

Closed
opzesty opened this issue Oct 25, 2022 · 7 comments
Closed

[CLI] sift-cli installer broken due to python dependency changes #579

opzesty opened this issue Oct 25, 2022 · 7 comments

Comments

@opzesty
Copy link

opzesty commented Oct 25, 2022

Not sure if this should be under CLI or the main project....however

SIFTSaltStack.log

Per the above SaltStack log, SIFT version v2022.01.22 breaks when attempting to run python utilizing the importlib-metadata library.

The latest version of this library appears to change its previous return type (was a dict, now is a list), which breaks quite a lot of code relying on this. I believe they are not reverting this change, and code should be updated to work with lists. Issue is listed here.

@digitalsleuth
Copy link

Hi @opzesty , we are tracking this issue. Can you tell me what OS you're attempting to install on, and the current version of Python it's running?

@opzesty
Copy link
Author

opzesty commented Oct 25, 2022

Of course!

OS: Ubuntu 20.04 Focal Fossa
Python: 3.8.10

@digitalsleuth
Copy link

Could you try running the following and see if this works:

sudo python3 -m pip install importlib-metadata==4.13.0

Then try running the installer.

@opzesty
Copy link
Author

opzesty commented Oct 25, 2022

running:
$ sudo pip install -Iv 'importlib-metadata<5.0.0'
(which I believe does the same thing)

then running the installer works

I can check your command specifically tomorrow if you would like

@opzesty
Copy link
Author

opzesty commented Oct 26, 2022

checked and running

sudo python3 -m pip install importlib-metadata==4.13.0

does allow SIFT to install.

@digitalsleuth
Copy link

Hi @opzesty , you're correct, your command would work as well, I just wanted to make sure importlib-metadata was pinned to a confirmed working version, but anything under 5 is acceptable anyways.
Glad to hear you got this working. I'll see if I can come up with a way to prevent this issue in the future, but I know the SaltStack team is also working on it.

Cheers!

@ekristen
Copy link
Contributor

ekristen commented Feb 1, 2023

Please also note, that once teamdfir/sift-saltstack#80 is merged, SIFT CLI will be officially deprecated as of March 1, 2023, and is replaced with cast

@ekristen ekristen closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants