Two issues after upgrading PHP and TNTSearch - nostemmerstemmer and curly braces

[rkyoku]

Hi there!

After upgrading PHP (7.4.27) and TNTSearch (using @stable), I am experiencing multiple issues that prevent me from going live.

nostemmerStemmer

I get the error:

Fatal error: Uncaught Error:
Class 'TeamTNT\TNTSearch\Stemmer\Teamtnt\tntsearch\stemmer\nostemmerStemmer' not found
    in /media/webapps/project/lib/vendor/teamtnt/tntsearch/src/TNTSearch.php:264
Stack trace:
    #0 /media/webapps/project/lib/vendor/teamtnt/tntsearch/src/TNTSearch.php(35):
        TeamTNT\TNTSearch\TNTSearch->setStemmer()

My code:

$this->_tnt->loadConfig([
    'storage' => $sPath,
    // 'stemmer' => \TeamTNT\TNTSearch\Stemmer\NoStemmer::class // PorterStemmer
]);
$this->_tnt->selectIndex('Product');

Please note that it doesn't matter that I choose a Stemmer or not, and which one. I get the same error no matter what.

Maybe the stemmer full class name was stored in the data, and with this new version, the way of storing/using it changed, and the backward compatibility was somehow imperfect?

SELECT * FROM info WHERE key = 'stemmer' gives TeamTNT\TNTSearch\Stemmer\NoStemmer, which is then strtolowered etc.

But, seeing how it is used, I think removing the namespaces and also the pending "stemmer" would work fine, and be backward compatible.

Curly braces

Finally, for the biggest issue if I may: I told myself "maybe my data is too old and incompatible with this new version of TNTSearch, I ought to build it again".

But then, when I tried, I got the error:

PHP Fatal error:  Uncaught ErrorException:
    Array and string offset access syntax with curly braces is deprecated
    in /media/webapps/project/lib/vendor/teamtnt/tntsearch/src/Stemmer/PorterStemmer.php:382

Which prevents me from building the data again.

However, curly braces access was deprecated in PHP 7.4 (nov. 2019). But the composer.json file indicates that TNTSearch is compatible with PHP up to version 8.

Is there a configuration that I should modify in my php.ini for this to work?

---

All in all, is there something I did wrong? What should I do?

I'd like to avoid cloning the repo if possible.

Thanks!

Best,

[nticaric]

You can create a PR for the porter stemmer and replace the offset access syntax with curly braces

Like this:

 $var[$idx] instead of $var{$idx}