Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI re-index output is confusing #312

Open
ViliusS opened this issue Apr 17, 2024 · 0 comments
Open

CLI re-index output is confusing #312

ViliusS opened this issue Apr 17, 2024 · 0 comments

Comments

@ViliusS
Copy link
Contributor

ViliusS commented Apr 17, 2024

When dataset has > 1000 rows but less than 2000 rows the output of CLI re-index script is confusing:

[] bin/plugin tntsearch index

Re-indexing

Language: en
Added   1 /
Added   2 /home
Added   3 /home/sweet
.........
Added   1085 /another/link
Added   1086 /test
Processed 1000 rows
Total rows 1086

It is not clear if only 1000 rows from 1086 were processed and the index is missing some data or not. I had to track down it to

$this->info("Processed $counter $object");
to actually tell that data is probably processed, and this is only the output of first step.

I'm not sure what is the proper way to fix this, but this either should output rows in every step, in my case:

Processed 1000 rows
Processed 86 rows
Total rows 1086

or it should be reworded to actually say that this is step 1, step 2, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant