From ddee9d886f150f038d7e038e707a3ff4608c1ffa Mon Sep 17 00:00:00 2001 From: Theodore Abshire Date: Thu, 10 Feb 2022 13:05:49 +0100 Subject: [PATCH] fix(ads): Dispose of ad manager on player detach Change-Id: Ie4cd186885349ecb9081f16e82790295113668c2 --- lib/ads/server_side_ad_manager.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/ads/server_side_ad_manager.js b/lib/ads/server_side_ad_manager.js index de8bbd16d8..18f175fae2 100644 --- a/lib/ads/server_side_ad_manager.js +++ b/lib/ads/server_side_ad_manager.js @@ -226,6 +226,14 @@ shaka.ads.ServerSideAdManager = class { } } + /** @override */ + release() { + this.stop(); + if (this.eventManager_) { + this.eventManager_.release(); + } + } + /** * @param {string} type * @param {Uint8Array|string} data