From e70ce007bf70ebfc0ced394f0b68f33bd0f85f37 Mon Sep 17 00:00:00 2001 From: Thibault Derousseaux Date: Tue, 16 Jul 2019 15:06:48 +0200 Subject: [PATCH] Default to production build Now that the production build is fixed, I think it's better to default to it. Indeed, we want users installing JupyterLab to have the best experience using the interface and it means running the optimized production build. This is especially true for extensions built with React because in dev mode, they will use the React's development bundle which is known to be much slower than the production one. See also: https://github.com/jupyterlab/jupyterlab/issues/6804#issuecomment-510721047 --- jupyterlab/labapp.py | 4 ++-- jupyterlab/labextensions.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/jupyterlab/labapp.py b/jupyterlab/labapp.py index 32bba4f524d0..4ef81e1ca8ae 100644 --- a/jupyterlab/labapp.py +++ b/jupyterlab/labapp.py @@ -61,8 +61,8 @@ class LabBuildApp(JupyterApp, DebugLogFileMixin): version = Unicode('', config=True, help="The version of the built application") - dev_build = Bool(True, config=True, - help="Whether to build in dev mode (defaults to dev mode)") + dev_build = Bool(False, config=True, + help="Whether to build in dev mode (defaults to prod mode)") pre_clean = Bool(False, config=True, help="Whether to clean before building (defaults to False)") diff --git a/jupyterlab/labextensions.py b/jupyterlab/labextensions.py index 09b6802b3b0e..54f8a654c0d9 100644 --- a/jupyterlab/labextensions.py +++ b/jupyterlab/labextensions.py @@ -69,8 +69,8 @@ class BaseExtensionApp(JupyterApp, DebugLogFileMixin): should_build = Bool(True, config=True, help="Whether to build the app after the action") - dev_build = Bool(True, config=True, - help="Whether to build in dev mode (defaults to dev mode)") + dev_build = Bool(False, config=True, + help="Whether to build in dev mode (defaults to prod mode)") should_clean = Bool(False, config=True, help="Whether temporary files should be cleaned up after building jupyterlab")