Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Telegram::getFileLink with Telegram::downloadFile #1703

Closed
wojpawlik opened this issue Sep 24, 2022 · 3 comments · Fixed by #1705
Closed

Replace Telegram::getFileLink with Telegram::downloadFile #1703

wojpawlik opened this issue Sep 24, 2022 · 3 comments · Fixed by #1705
Labels
Projects
Milestone

Comments

@wojpawlik
Copy link
Member

No description provided.

@KnorpelSenf
Copy link
Collaborator

Replace? So there will be no way to obtain the link anymore?

@MKRhere
Copy link
Member

MKRhere commented Sep 24, 2022

It's unsafe to expose outside of that context anyway. And if user wishes to for an obscure usecase, they could also construct the link themselves using file_id and token.

Is there any merit to being able to obtain the link other than being able to download the file?

@KnorpelSenf
Copy link
Collaborator

It's sometimes leaking a token, but not always (not even in the following cases)

  • streaming it
  • sending the link to other APIs which can directly download the file
  • sending the link to a user to download the file

wojpawlik added a commit that referenced this issue Sep 26, 2022
@wojpawlik wojpawlik linked a pull request Sep 27, 2022 that will close this issue
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
V5 Roadmap
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants