Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIDL from the examples/project.json generates undefined links in the output. #447

Open
JayaKrishnaNamburu opened this issue Jun 2, 2020 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest

Comments

@JayaKrishnaNamburu
Copy link
Member

The UIDL that we are currently using from the examples/project.json folder is generating #undefined links.

        <textblock>
          <a href="#undefined">
            <span className={styles.text}>Get Started →</span>
          </a>
        </textblock>
@JayaKrishnaNamburu JayaKrishnaNamburu added bug Something isn't working good first issue Good for newcomers labels Jun 2, 2020
@dhrubesh
Copy link

dhrubesh commented Jun 6, 2020

@JayaKrishnaNamburu to what I understand from https://github.com/teleporthq/teleport-code-generators/blob/master/packages/teleport-types/src/uidl.ts#L207
content doesn't accept id key it accepts section, replacing id with section resolves it, but I'm still getting several errors mostly around components which have type: 'local' when I run npm run standalone, are these 2 problems related?

@JayaKrishnaNamburu
Copy link
Member Author

Hi @dhrubesh a recent update to master introduced this issue. The project.json needs some updates to run in the current master. I have handled it to run properly in an open pr. feature/reusable-styles. Which we will be merging soon. Please use that PR, if you want to get along the project till it gets merged in master. 😀

@dhrubesh
Copy link

dhrubesh commented Jun 6, 2020

@JayaKrishnaNamburu Looks like this issue resolved in feature/reusable-styles.

@JayaKrishnaNamburu
Copy link
Member Author

Yes, i solved it. Just waitjng for it to merge. You can use it for now to understand the code 😀

@dhrubesh
Copy link

dhrubesh commented Jun 6, 2020

@JayaKrishnaNamburu I think b68472b this commit resolves it. Anyways, let me know if there are any more good first issue, I'll be happy to spend some time 😃

@JayaKrishnaNamburu
Copy link
Member Author

That's the commit which actually introduced this, the current open PR solves it.

@JayaKrishnaNamburu
Copy link
Member Author

Hi @dhrubesh the PR is closed now, and you can replicate this issue directly on master. Let me know if you want to have a shot at this issue, and if needed some help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants