Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@progress/kendo-licensing semver security vulnerability #1620

Open
tplante opened this issue Jun 28, 2023 · 4 comments
Open

@progress/kendo-licensing semver security vulnerability #1620

tplante opened this issue Jun 28, 2023 · 4 comments
Labels
Discussion Technical discussion, questions, input needed

Comments

@tplante
Copy link

tplante commented Jun 28, 2023

  • Bug report

Current behavior

Latest version of @progress/kendo-licensing (1.3.0) has a dependency on semver@7.3.8, which exposes a security vulnerability. This is fixed in semver@7.5.2.

Expected behavior

@progress/kendo-licensing has up-to-date, secure dependencies.

Minimal reproduction of the problem with instructions

This vulnerability was reported by snyk.io. To reproduce:

  1. Install @progress/kendo-licensing in your project
  2. Configure Snyk
  3. See semver ReDoS vulnerability

What is the motivation or use case for changing the behavior?

Securing applications that depend on @progress/kendo-licensing

Environment

Package versions:

1.3.0

Browser:
N/A

System:
N/A

Snyk report:
Screenshot 2023-06-28 at 11 52 39 AM

@tsvetomir
Copy link
Member

tsvetomir commented Jul 4, 2023

This looks like a false positive, but might be due to a stale package-lock.json file. Try updating the dependencies in your project using npm update.

In more detail, @progress/kendo-licensing depends on jsonwebtoken 9.0.0 which loosely specifies "semver": "^7.3.8". NPM should pick up the latest version during an update.

@tplante
Copy link
Author

tplante commented Jul 5, 2023

@tsvetomir I regularly upgrade dependencies, but because of the indirect relationship to semver I don't have control over its version. Yarn only lists dependency versions one layer deep--here's how my yarn.lock looks:

"@progress/kendo-licensing@^1.3.0":
  version "1.3.0"
  resolved "https://registry.yarnpkg.com/@progress/kendo-licensing/-/kendo-licensing-1.3.0.tgz#92cb1033c56e5b86ef0c5d81ea83e887b4557614"
  integrity sha512-Bp5MUX6wVHVUW8ZJUNcFVw9/KwRvP/a9zg2gAwRhpHVlwrSPbIpCMoBRRk32CEzC1tpUsIuQywT95+97HXZDTg==
  dependencies:
    jsonwebtoken "^9.0.0"

Is it possible to resolve this without action from jsonwebtoken?

@tsvetomir
Copy link
Member

It should be possible to override indirect dependency versions through the resolutions section:

"resolutions": {
  "semver": "^7.5.2"
}

@tsvetomir
Copy link
Member

Also reported in auth0/node-jsonwebtoken#921 and auth0/node-jsonwebtoken#905

@WissamProgress WissamProgress added the Discussion Technical discussion, questions, input needed label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Technical discussion, questions, input needed
Projects
None yet
Development

No branches or pull requests

3 participants