Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Silently ignoring errors when access_token has wrong scope #50

Open
itsdalmo opened this issue Oct 26, 2018 · 1 comment
Open

Bug: Silently ignoring errors when access_token has wrong scope #50

itsdalmo opened this issue Oct 26, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@itsdalmo
Copy link
Contributor

Ref #48, it seems like check is silently ignoring errors (when the scope of the access_token did not grant private repository access. Most likely a 404 was returned, but whichever error was returned should have been output in the task and resulted in a non-zero exit code.

@itsdalmo itsdalmo added the bug Something isn't working label Oct 26, 2018
@itsdalmo
Copy link
Contributor Author

itsdalmo commented Apr 2, 2019

I believe this might be related: shurcooL/githubv4#41. However, the Query() implementation should bubble up errors for non-200 status codes from the underlying client - and I would expect a 404 not found to be returned if the access token has the wrong scope 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant