Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ensure all samples can be fully built, run and validated in automated way #259

Open
mjameswh opened this issue Apr 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mjameswh
Copy link
Contributor

mjameswh commented Apr 4, 2023

What

Add a script on each sample that perform a completely automated validation of that sample.

Why

High quality samples are essential to allow users to learn and start using Temporal. Unfortunately, from time to time, some sample stops working. Common situations leading to sample failure are dependencies getting updated in incompatible ways, and Temporal SDK itself introducing breaking changes.

At the moment, testing samples is unreasonably time consuming, notably because samples doesn't all follow the same execution semantic (most are using npm run start and npm run workflow, but ~25% require different steps), some require particular environment (eg. Mongo), and because "success" is not always obvious.

@mjameswh mjameswh added the enhancement New feature or request label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant