Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add example of bundling with a payload converter #324

Open
clintonb opened this issue Dec 22, 2023 · 2 comments
Open

[Feature Request] Add example of bundling with a payload converter #324

clintonb opened this issue Dec 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@clintonb
Copy link

Is your feature request related to a problem? Please describe.

I have bundling working following the example at https://github.com/temporalio/samples-typescript/tree/f16fa9d4962c31231ea63c0a7c7dada3c52a840a/production.

I can use a custom payload converter following the example at https://github.com/temporalio/samples-typescript/tree/main/ejson.

How do I combine the two? When I bundle with a payload converter, I get an error from Temporal client setup:

ValueError: Could not find a file at the specified payloadConverterPath: './shared/temporal/payload-converter.ts'.

Describe the solution you'd like

Explain how to use a payload converter with a client bundled by Webpack.

Additional context

@clintonb clintonb added the enhancement New feature or request label Dec 22, 2023
@clintonb
Copy link
Author

@bergundy
Copy link
Member

To combine the two samples, you'll need to pass payloadConverterPath to bundleWorkflowCode, I don't think that warrants a dedicated sample.

That being said, our production sample could use an upgrade IMHO, it's fairly basic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants