Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail workflow task on illegal calls in Workflow.await #2044

Open
Quinn-With-Two-Ns opened this issue Apr 19, 2024 · 0 comments
Open

Fail workflow task on illegal calls in Workflow.await #2044

Quinn-With-Two-Ns opened this issue Apr 19, 2024 · 0 comments
Labels
enhancement User experience

Comments

@Quinn-With-Two-Ns
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Workflow.await is expected to be idempotent, so it is not allowed to make any calls to mutate workflow state like start an activity. If we detect any such call we should fail the workflow task since it indicates a bug in the workflow implementation.

boolean activityExecuted = Workflow.await(Duration.ofSeconds(5), () -> {
    activity.doSomething();
    return true;
});
@Quinn-With-Two-Ns Quinn-With-Two-Ns added the enhancement User experience label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement User experience
Projects
None yet
Development

No branches or pull requests

1 participant