Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toString method to WorkflowServiceStubsOptions #2047

Open
tsurdilo opened this issue Apr 29, 2024 · 4 comments
Open

Add toString method to WorkflowServiceStubsOptions #2047

tsurdilo opened this issue Apr 29, 2024 · 4 comments
Labels
enhancement User experience

Comments

@tsurdilo
Copy link
Contributor

improvement request to add toString method to WorkflowServiceStubsOptions that would print out all options available. can be extended to any/all other options type of classes

@tsurdilo tsurdilo added the enhancement User experience label Apr 29, 2024
@dskarbek
Copy link

Please make sure to add a toString method to the Builder sub-class as well so we can log what options we are building with.

@Quinn-With-Two-Ns
Copy link
Contributor

Quinn-With-Two-Ns commented Apr 29, 2024

We should also include equals and hashcode like all other *Options in the Java SDK. The Builder can be converted to a WorkflowServiceStubsOptions to be logged so you will get an accurate log of what options are actually set logging the Builder does not.

@Quinn-With-Two-Ns
Copy link
Contributor

We also need to do this for OperatorServiceStubsOptions though that is much less frequently used.

@dskarbek
Copy link

dskarbek commented Apr 29, 2024

The Builder can be converted to a WorkflowServiceStubsOptions to be logged

So long as there's no failures that the build method will trigger on a partially filled out Builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement User experience
Projects
None yet
Development

No branches or pull requests

3 participants