Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched failure message and timeoutFailureInfo #5914

Closed
yycptt opened this issue May 13, 2024 · 0 comments
Closed

Mismatched failure message and timeoutFailureInfo #5914

yycptt opened this issue May 13, 2024 · 0 comments

Comments

@yycptt
Copy link
Member

yycptt commented May 13, 2024

Expected Behavior

  • Failure message should match the timeout failure info

Actual Behavior

{
  "message": "activity StartToClose timeout",
  "source": "Server",
  "stackTrace": "",
  "encodedAttributes": null,
  "cause": {
    "message": "activity StartToClose timeout",
    "source": "Server",
    "stackTrace": "",
    "encodedAttributes": null,
    "cause": null,
    "timeoutFailureInfo": {
      "timeoutType": "StartToClose",
      "lastHeartbeatDetails": null
    }
  },
  "timeoutFailureInfo": {
    "timeoutType": "ScheduleToClose",
    "lastHeartbeatDetails": null
  }
}

Steps to Reproduce the Problem

^ happens when we force update the timeoutFailureInfo here, when activity retry would exceed the schedule to close timeout.
The timeoutFailureInfo got updated but not the failure message.

Specifications

  • Version:
  • Platform:
yycptt added a commit that referenced this issue May 17, 2024
## What changed?
<!-- Describe what has changed in this PR -->
- Fix activity failure message upon retry timeout

## Why?
<!-- Tell your future self why have you made these changes -->
- #5914

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- Unit test

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
@sync-by-unito sync-by-unito bot closed this as completed May 17, 2024
ychebotarev pushed a commit to ychebotarev/temporal that referenced this issue May 20, 2024
## What changed?
<!-- Describe what has changed in this PR -->
- Fix activity failure message upon retry timeout

## Why?
<!-- Tell your future self why have you made these changes -->
- temporalio#5914

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- Unit test

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant