Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer not loading in macOS & iOS devices (raster, vector,.. ) #43

Open
laraduarte opened this issue Nov 9, 2022 · 5 comments
Open

Layer not loading in macOS & iOS devices (raster, vector,.. ) #43

laraduarte opened this issue Nov 9, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@laraduarte
Copy link

System: Ipad, iOS 15.6
Browser: Google Chrome
No errors in the console.
https://tentone.github.io/geo-three/index.html

Thank you!

@tentone tentone added the bug Something isn't working label Nov 9, 2022
@tentone
Copy link
Owner

tentone commented Nov 9, 2022

Hello

Can you provide additional detail, is this only specific to the Bing map provider?

What happens on screen?

Thanks a lot!

@laraduarte
Copy link
Author

laraduarte commented Nov 9, 2022

@tentone any layer!

IPad Preview (not working)
image

Safari Preview (not working)
image

Android Preview (working)
image

you can try to preview with browserstack.com

The request tile function is working I can tell by the logs!
image

Some info regarding errors (tested in different iPad versions)
image
image
image

thanks

@laraduarte laraduarte changed the title Bing layer not loading on Ipad Layer not loading on Ipad (raster, vector,.. ) Nov 9, 2022
@laraduarte laraduarte changed the title Layer not loading on Ipad (raster, vector,.. ) Layer not loading on iOS (raster, vector,.. ) Nov 9, 2022
@laraduarte laraduarte changed the title Layer not loading on iOS (raster, vector,.. ) Layer not loading in macOS & iOS (raster, vector,.. ) Nov 9, 2022
@laraduarte laraduarte changed the title Layer not loading in macOS & iOS (raster, vector,.. ) Layer not loading in macOS & iOS devices (raster, vector,.. ) Nov 9, 2022
@laraduarte
Copy link
Author

laraduarte commented Nov 10, 2022

@tentone this small change seems to fix it!

image

I would like to request small changes if that's ok

  1. only fetch tile if any of these values is defined if (zoom || x || y) (raster provider) to avoid the error below
    image

  2. the request protocol to be // instead of HTTP to avoid warnings when running on an HTTPS connection.
    Maybe checking the location.protocol it's a better option -> location.protocol ? 'http' ? 'http' : 'https'

Requested Changes
image

The white tiles are still an issue, I'm not sure why it happens but I will have a closer look at this
image
image

Thanks

@tentone
Copy link
Owner

tentone commented Nov 10, 2022

Wow! Thanks a lot! Do you want to open a PR for this fix or should i update it in the lib?

Thanks a lot!

@laraduarte
Copy link
Author

@tentone please update and release a new version as soon as you can :)
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants