Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map installed by npm and map run in example have different colors #67

Open
clearisoft opened this issue Nov 21, 2023 · 8 comments
Open
Labels
question Further information is requested

Comments

@clearisoft
Copy link

3

I do not known why? :(

@tentone
Copy link
Owner

tentone commented Nov 21, 2023

Hello

These are probably using different providers.

The provider will indicate the source of the map tiles (mapbox, google maps, etc)

@tentone tentone added help wanted Extra attention is needed question Further information is requested and removed help wanted Extra attention is needed labels Nov 21, 2023
@clearisoft
Copy link
Author

Hello Tentone:
But I use the same provider(bingmap)
var provider = new BingMapsProvider('', BingMapsProvider.AERIAL);
var map = new MapView(MapView.PLANAR, provider);

@clearisoft
Copy link
Author

I have carefully examined the examples in the example and my program, and noticed that the URLs of the images referenced in the tiles are exactly the same. However, when rendered, the visuals in my program appear brighter, as if there is lighting in the scene. In reality, there is no lighting in the scene.

@tentone
Copy link
Owner

tentone commented Nov 21, 2023

The example has lights set, so thats might be the difference

@clearisoft
Copy link
Author

I fix it,it is a bug of three.js after 0.152.0

@tobias74
Copy link

tobias74 commented Jan 2, 2024

I have the same problem. Reverting to 0.151.3 of three.js solved the issue. My question now would be: Is this really a bug in three.js, or rather some sort of incompatibility that could be resolved otherwise? For me reverting to 0.151.3 of three.js is not possible because it introduces lighting and contrast problems in other areas of my project...

I have found this in the release notes of threejs for version 0.152: https://discourse.threejs.org/t/updates-to-color-management-in-three-js-r152/50791

Quote from the release notes: "The upcoming release r152 will contain changes affecting color and lighting."

@tentone
Copy link
Owner

tentone commented Jan 3, 2024

This might be caused by the changes in color management in three.js

I will update the project to use the latest version and test to ensure that colors are kept as they were.

@tentone
Copy link
Owner

tentone commented Jan 3, 2024

A simple to get around would be to disable color management in project, but its not the correct way to go about it.

image

I will update all color usage in the project to be as close as possible to the old model, but it is expect to have some differences in the end result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants