Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure types are exported #388

Open
fabiospampinato opened this issue Feb 16, 2023 · 3 comments
Open

Ensure types are exported #388

fabiospampinato opened this issue Feb 16, 2023 · 3 comments

Comments

@fabiospampinato
Copy link

Describe the bug

It looks like a file containing types for this library is included in the repo, but it's kind of exported in package.json.

To Reproduce

  1. Import prompts
  2. Notice how there are no types

Expected behavior

I think there should be something like the following in package.json:

"types": "./index.d.ts",

Additional context

N/A

@joeykilpatrick
Copy link
Contributor

Types were recently migrated from @types/prompts to this package, but no new package version has been published that include these types. But you can still use @types/prompts.

@ThomasGormley
Copy link

ThomasGormley commented Mar 12, 2023

Hi @joeykilpatrick,my PR to @types/prompts was recently merged - will maintainers re-sync types with there for the next release? Or should I make the same & further changes to this repo?

@Phoscur
Copy link

Phoscur commented May 10, 2023

Noticed the missing types in v2.4.2 today when I tried to remove the @types/prompts package in the hope of getting types for the prompts.override(yargs) use case - no luck and probably worth another ticket?

Edit: Had an old @types/prompts package, version 2.4.4 has the override function type I was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants