Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somewhat different published module than the one in the repo #401

Open
fabiospampinato opened this issue Aug 9, 2023 · 2 comments
Open

Comments

@fabiospampinato
Copy link

Describe the bug

index.js in the repo looks like this:

Screen Shot 2023-08-09 at 12 49 26

But on NPM it actually looks like this:

Screen Shot 2023-08-09 at 12 49 49

I don't understand where this is coming from, but this should be fixed, Node v8 is even explicitly listed as unsupported in package.json, and this issue cases the already not super lightweight library to be included twice in bundled terminal apps, which is not good. (bundling improves startup time, which is important for terminal apps).

To Reproduce

Compare the index.js from github and npm.

Expected behavior

Prompts should be only imported once, in a bundler-friendly manner, besides these differences in the package between what's in the repo and what's published raise security concern eyebrows in general.

System

N/A

Additional context

N/A

@davidbielik
Copy link

I also don't see the same files, or the index.d.ts typescript support even though i installed the latest version 2.4.2

@joeykilpatrick
Copy link
Contributor

Version 2.4.2 is the latest release. There have been 4 commits on master since then. Both of the changes mentioned above are more recent than the last release.

You can see the differences between 2.4.2 and master here.

Discontinuing support for previous node versions requires a major version change (so 3.x.x). I've outlined a few ideas for what a 3.0 release might look like in #393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants