Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #29

Closed
wants to merge 2 commits into from
Closed

Fix bug #29

wants to merge 2 commits into from

Conversation

chenxsan
Copy link

@chenxsan chenxsan commented Sep 1, 2018

Should hopefully fix #28.

@chenxsan
Copy link
Author

chenxsan commented Sep 1, 2018

Guess the benchmark needs update too :)

@terkelg
Copy link
Owner

terkelg commented Sep 2, 2018

Thanks for the PR. I think we have to look into why the line is there in the first place. I'm pretty sure it's to avoid crawling unnecessary directories. We have to do some detective work here ;-)

@terkelg
Copy link
Owner

terkelg commented Sep 3, 2018

Discussion continues in #28.

@terkelg terkelg closed this Sep 3, 2018
@chenxsan chenxsan deleted the add-failing-test branch September 4, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some files are missing when doing glob
2 participants