-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_autoscaling_traffic_source_attachment add downtime VS target_group_arns #262
Comments
This issue has been automatically marked as stale because it has been open 30 days |
Bump |
Its not clear what you are looking for with this issue |
Hello! Hmm... It looks like your strategy on some modules is to use extra resources when they are available even if we can configure the parameter in the native resource. Here the example with "aws_autoscaling_group" and the parameter "target_group_arns" that you quote "to remove" in the module. You prefer to use the extra resource "aws_autoscaling_traffic_source_attachment" for the same result. But with extra resource to configure the same thing than the main resource you add lifecycle issues and downtime to HTTP traffic. Detailed in the main post. Regards, |
Hello same issue here |
I would suggest opening an issue upstream with the AWS provider. The |
This issue has been automatically marked as stale because it has been open 30 days |
Description
Hello,
We migrate code from:
to
But this change add like 2 minutes of downtime (ASG time creation) when we have an ASG re-creation because Terraform:
1 - delete existing aws_autoscaling_traffic_source_attachment
2 - create ASG
3 - create new existing aws_autoscaling_traffic_source_attachment
LOGS (trigger a new creation of ASG):
With "target_group_arns" there is no downtime (checked with $ watch -n 0.2 'curl -ILk -s https://...'). But your comment in the main.tf looks scary
I tried to fixed it by adding a lifecycle in "aws_autoscaling_traffic_source_attachment":
It's better, but traffic is mixed between old and new asg, and during 1minute with some http 200 and http 502. Still shitty.
LOGS with lifecycle:
Please DO NOT REMOVE "target_group_arns" with way better than additional attachments.
Thanks,
Regards
Florian
Versions
The text was updated successfully, but these errors were encountered: