Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update package.py - fixed docker volume #183

Closed
wants to merge 7 commits into from
Closed

fix: Update package.py - fixed docker volume #183

wants to merge 7 commits into from

Conversation

mliner
Copy link

@mliner mliner commented Jul 19, 2021

Fixed adding root/.ssh folder into docker command only when ssh_agent is enabled.

Fixes #178

Description

When creating package in docker container there is a default docker command imported that adds /root/.ssh as volume. However in cases when you run this in a pipeline (like bitbucket) you don't have such volume available - importing of /root/.ssh/known_hosts should be only available when you want to use ssh agent.

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

Fixed adding root/.ssh folder into docker command only when ssh_agent is enabled
@mliner mliner changed the title Update package.py Update package.py - fixed docker volume Jul 19, 2021
@mliner mliner changed the title Update package.py - fixed docker volume fix: Update package.py - fixed docker volume Jul 19, 2021
@antonbabenko
Copy link
Member

Hi!

Thanks for the PR.

Could you please show the terraform code snippet which failed using the code in the master branch and is fixed using this PR?

@Ranchman42
Copy link

Can this be merged in? I believe i am suffering from the same issue that this fixes. Thanks!

@antonbabenko
Copy link
Member

@Ranchman42 I'm waiting for the example code update to prove this PR does what it should (see my comment above)

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 11, 2022
@github-actions
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Jan 23, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline - unable to build in docker
3 participants