fix: Don't use var.(in|e)gress_ipv6_cidr_blocks on security group sourced (in|e)gress #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… apply egress_ipv6_cidr_blocks for security group sourced egress
michaelaw320
changed the title
|
@antonbabenko can you take a look at this? |
|
Can we get some traction on this? This is a big security issue. |
|
can we get some traction on this? |
|
Could we merge this ASAP? |
|
Hello @antonbabenko @tcarrondo can we release this? |
antonbabenko
changed the title
|
Thanks, @michaelaw320 and all of you who looked into this issue! v3.6.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't include
var.ingress_ipv6_cidr_blocksorvar.egress_ipv6_cidr_blocksfor security group sourced ingress / egress rules.Error such as:
Error message: the specified rule "peer: ::/0, TCP, from port: 3306, to port: 3306, ALLOW" already existsis caused by multiple redefinition of the same IPv6 cidr from the variables mentioned above
Fixes #147
Also fix: #130 #79