Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty the known issues section + pre-commit #150

Merged

Conversation

SolidSly
Copy link
Contributor

@SolidSly SolidSly commented Jan 2, 2020

Cf #144

When I performed the pre-commit run --all-files, a lot of files has been changed. Don't hesite to tell me I did the command in a wrong way.

@SolidSly
Copy link
Contributor Author

SolidSly commented Jan 2, 2020

@antonbabenko Hello, would you mind to check it and maybe merge it, since it changes nearly every README files, so people can continue to iterate on this module with all of the README cleaned. Thank you

@antonbabenko antonbabenko merged commit 14b4839 into terraform-aws-modules:master Jan 7, 2020
@antonbabenko
Copy link
Member

Thanks @SolidSly for this PR.

No "known issues" = no bugs, right? :)

pre-commit was not executed previously for some reason, so the large amount of files changed was correct.

v3.3.0 has been just released.

@SolidSly SolidSly deleted the fix/remove-issue-section branch January 10, 2020 07:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants