New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for kubernetes api server - 6443-tcp #166
Conversation
…sed rest services) on port 6433
rules.tf
Outdated
@@ -213,6 +215,11 @@ variable "auto_groups" { | |||
ingress_with_self = ["all-all"] | |||
egress_rules = ["all-all"] | |||
} | |||
kafka = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubernetes-api
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace kafka
with kubernetes-api
here.
I am using your module to spin up a self hosted modular kubernetes cluster. In order to be able to administer a kubernetes cluster, most of the people use kubectl, a binary executable that under the hood talks JSON REST HTTPS with the apiserver (the configuration server of kubernetes) which is running on one or more master nodes. Note that other configuration tools like Ansible and Terraform for administering kubernetes clusters use the same REST API on port 6443 to reach the target cluster of interest. More info at https://kubernetes.io/docs/reference/access-authn-authz/controlling-access/ |
Any update on this? I would like to add Grafana support as well, but like to wait to see if this one would be accepted first. |
Yes, I commented on it a few days ago. Please fix and I will merge this and another one. |
Ok, I did not see that remark. Typo fixed. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
The Kubernetes master server runs a REST API server exposed on 6443 and I would like to use this role to keep my code consistent with other rules already used from here.