Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for kubernetes api server - 6443-tcp #166

Merged
merged 2 commits into from Apr 16, 2020
Merged

Conversation

boeboe
Copy link
Contributor

@boeboe boeboe commented Apr 10, 2020

The Kubernetes master server runs a REST API server exposed on 6443 and I would like to use this role to keep my code consistent with other rules already used from here.

rules.tf Outdated
@@ -213,6 +215,11 @@ variable "auto_groups" {
ingress_with_self = ["all-all"]
egress_rules = ["all-all"]
}
kafka = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes-api ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace kafka with kubernetes-api here.

@antonbabenko antonbabenko changed the title Added support of kubernetes api server - 6443-tcp feat: Added support of kubernetes api server - 6443-tcp Apr 10, 2020
@boeboe
Copy link
Contributor Author

boeboe commented Apr 10, 2020

Hi @antonbabenko

I am using your module to spin up a self hosted modular kubernetes cluster. In order to be able to administer a kubernetes cluster, most of the people use kubectl, a binary executable that under the hood talks JSON REST HTTPS with the apiserver (the configuration server of kubernetes) which is running on one or more master nodes.

Note that other configuration tools like Ansible and Terraform for administering kubernetes clusters use the same REST API on port 6443 to reach the target cluster of interest.

More info at https://kubernetes.io/docs/reference/access-authn-authz/controlling-access/

@boeboe
Copy link
Contributor Author

boeboe commented Apr 14, 2020

Hi @antonbabenko

Any update on this? I would like to add Grafana support as well, but like to wait to see if this one would be accepted first.

@antonbabenko
Copy link
Member

Yes, I commented on it a few days ago. Please fix and I will merge this and another one.

@boeboe
Copy link
Contributor Author

boeboe commented Apr 15, 2020

Ok, I did not see that remark. Typo fixed.

@antonbabenko antonbabenko merged commit 7e35afa into terraform-aws-modules:master Apr 16, 2020
@antonbabenko
Copy link
Member

Thanks @boeboe !

v3.5.0 has been just released with this and your second PR merged.

@boeboe boeboe changed the title feat: Added support of kubernetes api server - 6443-tcp feat: Added support for kubernetes api server - 6443-tcp Apr 20, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants