Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use_name_prefix override in submodules #95

Merged
merged 1 commit into from Dec 28, 2018

Conversation

antonbabenko
Copy link
Member

This addition allows upgrade of this module without recreation of existing security groups.

Example:

module "http_mysql_1_sg" {
  source = "terraform-aws-modules/security-group/aws//modules/http-80"

  name            = "my-web-1"
  use_name_prefix = false
  # ...
}

Ref: #92 (comment)

@antonbabenko antonbabenko merged commit 469854a into master Dec 28, 2018
@antonbabenko antonbabenko deleted the use_name_prefix_in_submodules branch December 28, 2018 10:31
@antonbabenko
Copy link
Member Author

Thanks @puzzloholic for the idea!

v2.10.0 has been released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant