Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow allowed_principals for module vpc-endpoints #1057

Closed
kotowick opened this issue Mar 23, 2024 · 3 comments
Closed

Allow allowed_principals for module vpc-endpoints #1057

kotowick opened this issue Mar 23, 2024 · 3 comments
Labels

Comments

@kotowick
Copy link

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.

We are using RAM to share vpcs. This means we can only create VPC interface endpoints in the acount that owns the vpcs. It looks like AWS has an option to allow external principles to discover the endpoint.

The key is allowed_principals

I don't see this as an option in the terraform-aws-modules/vpc/aws//modules/vpc-endpoints.

Describe the solution you'd like.

Support for allowed_principals

Describe alternatives you've considered.

No possible alternatives

@RunCor399
Copy link
Contributor

I'm giving a look into this but I've noticed that the parameter allowed_principals you are referring to is only available when creating a resource of type aws_vpc_endpoint_service. However the vpc-endpoints module as of now just uses a data block to reference existing aws_vpc_endpoint_services.

I was thinking that maybe an inline policy defined within the aws_vpc_endpoint could be leveraged instead (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc_endpoint#policy).

Let me know your thoughts on this.

Copy link

github-actions bot commented May 8, 2024

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label May 8, 2024
Copy link

This issue was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants