Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent project names and envcode for networking projects #1198

Closed
eeaton opened this issue Apr 25, 2024 · 0 comments
Closed

Inconsistent project names and envcode for networking projects #1198

eeaton opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels

Comments

@eeaton
Copy link
Collaborator

eeaton commented Apr 25, 2024

TL;DR

Networking projects under the Networking folder do not follow the naming conventions or environment code labels as intended.

Expected behavior

Should match the documented design at https://cloud.google.com/architecture/security-foundations/organization-structure#projects and https://cloud.google.com/architecture/security-foundations/summary#naming-conventions

environmentcode is a short form of the environment field (one of b, c, p, n, d, or net). Shared VPC host projects use the environmentcode of the associated environment. Projects for networking resources that are shared across environments, like the interconnect project, use the net environment code.

It's also strange that "hub" is used inconsistently (in the current implementation, "dns-hub" means something different from "base-net-hub") so I'll clean that up as well.

Should look like:

└── fldr-network
├── prj-net-hub-base
├── prj-net-hub-restricted
├── prj-net-dns
├── prj-net-interconnect

├── prj-d-shared-base
├── prj-d-shared-restricted
├── prj-n-shared-base
├── prj-n-shared-restricted
├── prj-p-shared-base
└── prj-p-shared-restricted

Observed behavior

Common network projects like DNS, interconnect, and hub and spoke use the old naming conventions from v3, where these were all under the "common" ("c") folder.

└── fldr-network
├── prj-c-base-net-hub
├── prj-c-dns-hub
├── prj-c-interconnect
├── prj-c-restricted-net-hub

├── prj-d-shared-base
├── prj-d-shared-restricted
├── prj-n-shared-base
├── prj-n-shared-restricted
├── prj-p-shared-base
└── prj-p-shared-restricted

Terraform Configuration

n/a

Terraform Version

n/a

Additional information

No response

@eeaton eeaton added the bug Something isn't working label Apr 25, 2024
@eeaton eeaton self-assigned this May 23, 2024
@eeaton eeaton added backlog and removed bug Something isn't working labels May 23, 2024
@eeaton eeaton closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant