Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Merge duplicate instructions on GCP onboarding, roles, service enablements, billing and bootstrap project - continuation of 1175 #1204

Open
obriensystems opened this issue Apr 27, 2024 · 0 comments
Labels
backlog documentation Improvements or additions to documentation v5.0

Comments

@obriensystems
Copy link
Contributor

TL;DR

assigned to https://github.com/fmichaelobrien
PR developed in fork GoogleCloudPlatform/pbmm-on-gcp-onboarding#407

specifically the prerequisites sections with roles and service enablements duplicated across
"For the user who will run the procedures in this document, grant the following roles:"
and
"Enable the following additional services on your current bootstrap project"
in
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/0-bootstrap/README.md#prerequisites
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/0-bootstrap/README-Terraform-Cloud.md#requirements
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/0-bootstrap/README-GitLab.md#deploying-a-gitlab-cicd-compatible-environment
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/0-bootstrap/README-GitHub.md#requirements

no section in

Check each terraform module specific to the build agent - for example

Fix:
detail all common roles and service enablements in the main readme, put links back to this readme from the extended readme's and add specific roles/services per gitlab/github/terraform-cloud/ado in extended readme's

see

Terraform Resources

No response

Detailed design

No response

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog documentation Improvements or additions to documentation v5.0
Projects
None yet
Development

No branches or pull requests

2 participants