Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1-org/envs/shared/projects.tf interconnect and dns labels need alignment to changes in #1199 #1231

Closed
fmichaelobrien opened this issue May 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@fmichaelobrien
Copy link
Contributor

TL;DR

tef minor bug for label changes in https://github.com/terraform-google-modules/terraform-example-foundation/pull/1199/files#diff-d6697e7c916ba73d6ae87ff4b1ce67cabc9b9738ab31c9ba582e2a3218982838L279

https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/1-org/envs/shared/projects.tf#L253
match
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/1-org/envs/shared/projects.tf#L237

-    application_name  = "org-dns-hub"
+    application_name  = "org-net-dns"

and

-net-interconnect

just like in
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/1-org/envs/shared/projects.tf#L295

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

cloud shell

Terraform Version

1.3.10

Additional information

part of upstream sync in 387
pr assigned to fmichaelobrien

@fmichaelobrien fmichaelobrien added the bug Something isn't working label May 13, 2024
@fmichaelobrien
Copy link
Contributor Author

fmichaelobrien-macbookpro:terraform-example-foundation fmichaelobrien$ git status
On branch gh1231-1-org-labels
Your branch is up to date with 'origin/gh1231-1-org-labels'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   1-org/envs/shared/projects.tf

no changes added to commit (use "git add" and/or "git commit -a")
fmichaelobrien-macbookpro:terraform-example-foundation fmichaelobrien$ git diff
diff --git a/1-org/envs/shared/projects.tf b/1-org/envs/shared/projects.tf
index 681d857..4ba625e 100644
--- a/1-org/envs/shared/projects.tf
+++ b/1-org/envs/shared/projects.tf
@@ -176,7 +176,7 @@ module "interconnect" {
 
   labels = {
     environment       = "network"
-    application_name  = "org-interconnect"
+    application_name  = "org-net-interconnect"
     billing_code      = "1234"
     primary_contact   = "example1"
     secondary_contact = "example2"
@@ -250,7 +250,7 @@ module "dns_hub" {
 
   labels = {
     environment       = "network"
-    application_name  = "org-dns-hub"
+    application_name  = "org-net-dns"
     billing_code      = "1234"
     primary_contact   = "example1"
     secondary_contact = "example2"

fmichaelobrien added a commit to CloudLandingZone/terraform-example-foundation that referenced this issue May 13, 2024
@fmichaelobrien
Copy link
Contributor Author

closed based on review discussion in #1232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant