-
Notifications
You must be signed in to change notification settings - Fork 737
feat: Updates for TF 0.13 #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Makefile also has a reference to the developer tools image, terraform-example-foundation/Makefile Line 21 in cd42805
but using version
|
@daniel-cit yeah I lock it to latest 0.12.x in this PR #250 |
@rjerrems this is ready for review |
@@ -15,5 +15,5 @@ | |||
*/ | |||
|
|||
terraform { | |||
required_version = "~> 0.12.6" | |||
required_version = ">=0.13, <0.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it might be worthwhile continuing to support terraform > 0.12.6 until we start using terraform 0.13 features?
Overall LGTM, only thing is whether or not we should continue supporting > 0.12.6 for the time being given most of the users of the foundation will be on those versions right now. I'm open to either way, let me know what you think |
@rjerrems I was debating this as well. The only reason I kept it |
Perhaps we can do the development on the develop branch, then cut a release once we have adding 0.13 support / conditional modules? |
@rjerrems sgtm, I have switched the base :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #238 #226
Todo: