Fixing version of network_peering in step 4-projects #384
+36
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato-rudnicki
requested review from
bharathkkb,
rjerrems and
a team
as code owners
bharathkkb
requested changes
Mar 22, 2021
| peer_network = data.google_compute_network.shared_vpc.self_link | ||
|
|
||
| source = "terraform-google-modules/network/google//modules/network-peering" | ||
| version = "~> 2.0" |
There was a problem hiding this comment.
@bharathkkb should the peering_network module also be bumped to 3.x so that both are in sync?
module "peering_network" {
source = "terraform-google-modules/network/google"
version = "~> 2.0"
There was a problem hiding this comment.
The peered network is using 3.x:
|
Build |
bharathkkb
approved these changes
Mar 24, 2021
bharathkkb
pushed a commit
that referenced
this pull request
Mar 30, 2021
* Adding version on peering module * Adding version for network_peering module * Fix lint * fixing lint
bharathkkb
pushed a commit
that referenced
this pull request
Mar 30, 2021
* Adding version on peering module * Adding version for network_peering module * Fix lint * fixing lint
bharathkkb
pushed a commit
that referenced
this pull request
Mar 30, 2021
* Adding version on peering module * Adding version for network_peering module * Fix lint * fixing lint
bharathkkb
pushed a commit
that referenced
this pull request
Mar 31, 2021
* Adding version on peering module * Adding version for network_peering module * Fix lint * fixing lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 313 - Pin peering module version in networks
Added version in peering module for business unit 1 and 2 in example_peering_project.tf .