fix: Issue #628 Failed Cloud Build plan in 1-org using cloud build SA from TFV #629
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…org using cloud build SA from TFV
bharathkkb
requested changes
Feb 9, 2022
Let me know if the recent commit is what you are looking for @bharathkkb. |
bharathkkb
reviewed
Feb 17, 2022
There was a problem hiding this comment.
It looks like we will actually need roles/iam.securityReviewer as TFV will need to get IAM policy associated with any resource x-ref: #546. It also looks like organizationRoleViewer can only be granted at the org level
Thanks for catching that! Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
bharathkkb
approved these changes
Feb 22, 2022
This was referenced Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed my issue #628.