Modularize logging components #781
Merged
+620
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added logbucket as new logging destination
…ue as storage names
Co-authored-by: Daniel Andrade <dandrade@ciandt.com>
Co-authored-by: Daniel Andrade <dandrade@ciandt.com>
Co-authored-by: Daniel Andrade <dandrade@ciandt.com>
-Improve code readability using maps and lookup
felipecrescencio-cit
requested review from
a team,
rjerrems and
bharathkkb
as code owners
bharathkkb
reviewed
Aug 23, 2022
There was a problem hiding this comment.
Thanks for the PR @felipecrescencio-cit
Some initial comments
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
felipecrescencio-cit
force-pushed
the
modularize-logging-components
branch
from
96640b7 to
546c730
Compare
bharathkkb
reviewed
Sep 1, 2022
bharathkkb
approved these changes
Sep 7, 2022
This was referenced Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #674.
PR changes:
log-exportmodule and now it is supported by the example foundation1-orgto use the new moduleNOTE
Before merging this PR is required to release log-export module PR 119 to get fixes in logbucket destination. This PR is referencing logbucket submodule GitHub master branch.