-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dns response policy sub-module #55
feat: add dns response policy sub-module #55
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @maitreya-source
test/integration/dns_response_policy/controls/response_policy.rb
Outdated
Show resolved
Hide resolved
required_providers { | ||
google-beta = { | ||
source = "hashicorp/google-beta" | ||
version = "~> 4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you plz set this to ">= 4.75, < 5.0"
as response policy was moved to GA in 4.75?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maitreya-source This one should remain ">= 4.75, < 5.0"
as module needs version 4.75+. Example version.tf should always be set "~> 4.0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the module version to point to ">= 4.75, < 5.0" while keeping the example to ~> 4.0
Although trying to understand what would be the benefit in keeping the example version to ~> 4.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module will force example to use appropriate version.
@maitreya-source r u still working on this sub-module? |
Hi @imrannayer, yes, have not been able to find time for this due to other priorities, but I'll look into it this week. :) |
336b22f
to
b04ee66
Compare
b04ee66
to
2cfc2cb
Compare
2cfc2cb
to
7af52d0
Compare
@maitreya-source can you change provider in version.tf as follows:
|
Done @imrannayer |
@bharathkkb / @imrannayer thanks for the patience on this one. Let me know if any more changes are required. Thanks! |
/gcbrun |
6face1f
to
67810f6
Compare
/gcbrun |
/gcbrun |
Cloud DNS private zones allow customers to create response policies that can override the resolver behavior for DNS queries.
The sub-module contains following resources:
This allows customers to create policy, attach rules within the created policy and attach the policy to a VPC network.
NOTE: Both resources are currently under beta, thus the sub-module is using beta provider.
Testing
Removed sub-network from shared test module