Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test to check G Suite group creation #142

Closed
wants to merge 13 commits into from
Closed

Add unit test to check G Suite group creation #142

wants to merge 13 commits into from

Conversation

thefirstofthe300
Copy link
Contributor

Fixes #111.

@thefirstofthe300 thefirstofthe300 force-pushed the gsuite-group-testing branch 5 times, most recently from 4a666dc to 13b81d7 Compare February 21, 2019 22:29
@thefirstofthe300 thefirstofthe300 force-pushed the gsuite-group-testing branch 2 times, most recently from 62a5bf8 to 97ac0dd Compare February 22, 2019 00:34
@thefirstofthe300 thefirstofthe300 marked this pull request as ready for review February 22, 2019 00:46
morgante
morgante suggested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why gsuite_group test needs to be implemented in Python? Any reason this can't be a Ruby test in the standard suite?

@aaron-lane aaron-lane added the enhancement New feature or request label Jun 3, 2019
@aaron-lane aaron-lane requested a review from morgante June 10, 2019 21:26
aaron-lane
aaron-lane suggested changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefirstofthe300 please rebase this branch against master.

@thefirstofthe300
Copy link
Contributor Author

This PR is getting a bit stale so I'm gonna close it. If someone wants to base off my work, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienthebo adrienthebo adrienthebo left review comments

@aaron-lane aaron-lane aaron-lane requested changes

@morgante morgante Awaiting requested review from morgante

Assignees

@thefirstofthe300 thefirstofthe300

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand testing to cover G Suite functionality
5 participants
@thefirstofthe300 @adrienthebo @morgante @aaron-lane @nstogner