Add auto-generator for root, shared_vpc and gsuite_enabled modules #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKozlovsky
commented
Dec 19, 2019
SKozlovsky
commented
- resolve Autogenerate the different submodules #260
SKozlovsky
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
…g before deleting service account. main-file draft draft tmpl draft draft draft
…form-google-modules#338, 6.1.0 to CHANGELOG
SKozlovsky
force-pushed
the
feature/add-autogenerator
branch
from
6940209
to
8041b53
Compare
SKozlovsky
changed the title
morgante
suggested changes
Jan 6, 2020
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| function generate() { |
There was a problem hiding this comment.
If we're centralizing this in the devtools image, we should have the task defined there.
| # limitations under the License. | ||
|
|
||
| function generate() { | ||
| pip3 install --user -r /workspace/helpers/generate_modules/requirements.txt |
There was a problem hiding this comment.
Requirements should be installed in the image, not at runtime.
| @@ -0,0 +1,96 @@ | |||
| #!/usr/bin/env python3 | |||
|
@morgante This future is provided in the same way as autogeneration in the GKE module. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.