From 45215943968dc371d5198b8cb3d4fa956aa745dd Mon Sep 17 00:00:00 2001
From: leavesster <11785335+leavesster@users.noreply.github.com>
Date: Fri, 17 Nov 2023 01:30:14 +0800
Subject: [PATCH] fix!: safer_mysql module's `assign_public_ip` input should be
bool type (#541)
---
examples/mysql-private/main.tf | 2 +-
modules/safer_mysql/README.md | 2 +-
modules/safer_mysql/variables.tf | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/examples/mysql-private/main.tf b/examples/mysql-private/main.tf
index d641a923..20ed5079 100644
--- a/examples/mysql-private/main.tf
+++ b/examples/mysql-private/main.tf
@@ -94,7 +94,7 @@ module "safer-mysql-db" {
}
]
- assign_public_ip = "true"
+ assign_public_ip = true
vpc_network = module.network-safer-mysql-simple.network_self_link
allocated_ip_range = module.private-service-access.google_compute_global_address_name
diff --git a/modules/safer_mysql/README.md b/modules/safer_mysql/README.md
index 9a8f5995..76b09def 100644
--- a/modules/safer_mysql/README.md
+++ b/modules/safer_mysql/README.md
@@ -168,7 +168,7 @@ mysql -S $HOME/mysql_sockets/myproject:region:instance -u user -p
| additional\_databases | A list of databases to be created in your cluster | list(object({
name = string
charset = string
collation = string
})) | `[]` | no |
| additional\_users | A list of users to be created in your cluster. A random password would be set for the user if the `random_password` variable is set. | list(object({
name = string
password = string
host = string
type = string
random_password = bool
})) | `[]` | no |
| allocated\_ip\_range | Existing allocated IP range name for the Private IP CloudSQL instance. The networks needs to be configured with https://cloud.google.com/vpc/docs/configure-private-services-access. | `string` | `null` | no |
-| assign\_public\_ip | Set to true if the master instance should also have a public IP (less secure). | `string` | `false` | no |
+| assign\_public\_ip | Set to true if the master instance should also have a public IP (less secure). | `bool` | `false` | no |
| availability\_type | The availability type for the master instance. Can be either `REGIONAL` or `null`. | `string` | `"REGIONAL"` | no |
| backup\_configuration | The backup\_configuration settings subblock for the database setings | object({
binary_log_enabled = bool
enabled = bool
start_time = string
location = string
transaction_log_retention_days = string
retained_backups = number
retention_unit = string
}) | {
"binary_log_enabled": false,
"enabled": false,
"location": null,
"retained_backups": null,
"retention_unit": null,
"start_time": null,
"transaction_log_retention_days": null
} | no |
| create\_timeout | The optional timout that is applied to limit long database creates. | `string` | `"30m"` | no |
diff --git a/modules/safer_mysql/variables.tf b/modules/safer_mysql/variables.tf
index 98118178..14a9d8e1 100644
--- a/modules/safer_mysql/variables.tf
+++ b/modules/safer_mysql/variables.tf
@@ -211,7 +211,7 @@ variable "backup_configuration" {
variable "assign_public_ip" {
description = "Set to true if the master instance should also have a public IP (less secure)."
- type = string
+ type = bool
default = false
}