Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: adds availability_type for read_replicas #329

Merged

Conversation

g-awmalik
Copy link
Contributor

Addresses issue #328

build/int.cloudbuild.yaml Outdated Show resolved Hide resolved
modules/mysql/read_replica.tf Outdated Show resolved Hide resolved
@enocom
Copy link

enocom commented Aug 3, 2022

@g-awmalik thanks for this!

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

build/int.cloudbuild.yaml Outdated Show resolved Hide resolved
modules/mysql/variables.tf Show resolved Hide resolved
examples/postgresql-ha/main.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title feat:adds availability_type for read_replicas feat!: adds availability_type for read_replicas Aug 3, 2022
@comment-bot-dev
Copy link

@g-awmalik
Thanks for the PR! 🚀
✅ Lint checks have passed.

@g-awmalik g-awmalik merged commit e26861e into terraform-google-modules:master Aug 4, 2022
@g-awmalik g-awmalik deleted the feat/add-avail-type branch August 4, 2022 01:34
@@ -31,6 +31,10 @@ locals {
is_account_sa = trimsuffix(iu, "gserviceaccount.com") == iu ? false : true
}]

// HA method using REGIONAL availability_type requires point in time recovery to be enabled

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g-awmalik Do you have a reference for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants