Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded values forcing random_password recreation #445

Closed
kpocius opened this issue Mar 20, 2023 · 2 comments · Fixed by #446
Closed

Hardcoded values forcing random_password recreation #445

kpocius opened this issue Mar 20, 2023 · 2 comments · Fixed by #446
Labels
bug Something isn't working

Comments

@kpocius
Copy link
Contributor

kpocius commented Mar 20, 2023

TL;DR

Much like #418 there's a new issue which forces recreating all random passwords. This time it's cause by min_lower, min_upper, and min_numeric being hardcoded. The change was introduced in #443

Expected behavior

Updating the module without any other changes should not cause passwords to be recreated.

Observed behavior

All random passwords are being recreated due to changes in requirements:


  # module.postgresql.random_password.user-password must be replaced
-/+ resource "random_password" "user-password" {
!       bcrypt_hash = (sensitive value)
!       id          = "none" -> (known after apply)
!       min_lower   = 0 -> 1 # forces replacement
!       min_numeric = 0 -> 1 # forces replacement
!       min_upper   = 0 -> 1 # forces replacement
!       result      = (sensitive value)
        # (8 unchanged attributes hidden)
    }

Terraform Configuration

N/A

Terraform Version

N/A

Additional information

No response

@kpocius kpocius added the bug Something isn't working label Mar 20, 2023
@kpocius
Copy link
Contributor Author

kpocius commented Mar 20, 2023

@ravisiddhu, any chance you could handle this?

@ravisiddhu
Copy link
Contributor

Yes, I will work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants