Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules #491

Merged
merged 9 commits into from Aug 9, 2023
Merged

feat!: added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules #491

merged 9 commits into from Aug 9, 2023

Conversation

ibhaskar2
Copy link
Contributor

@ibhaskar2 ibhaskar2 commented Jul 19, 2023 •
edited

b/291924307

@ibhaskar2
Added Edition in mssql,mysql,postgresql, safer_sql
1116bf8 
and data_cache_config to mysql and safer_sql
modules
@ibhaskar2 ibhaskar2 requested a review from a team as a code owner July 19, 2023 16:59
@imrannayer imrannayer self-requested a review July 19, 2023 20:24
@imrannayer
Copy link
Collaborator

@ibhaskar2 you need to change min provider version to 4.74 as these features were part of the release.

@ibhaskar2 ibhaskar2 changed the title Added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules feat(sql): Added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules Jul 28, 2023
@ibhaskar2
Copy link
Contributor Author

@imrannayer can you review it and merge it?

@imrannayer
Copy link
Collaborator

@bharathkkb can you plz review?

@g-awmalik g-awmalik changed the title feat(sql): Added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules feat!: added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules Aug 1, 2023
@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik changed the title feat!: added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules feat: added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules Aug 1, 2023
g-awmalik
g-awmalik approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@g-awmalik g-awmalik changed the title feat: added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules feat!: added edition in mssql, mysql, postgresql, safer_sql and data_cache_config to mysql and safer_sql modules Aug 1, 2023
@g-awmalik
Copy link
Contributor

@isaurabhuttam - since this is a breaking change can you please add an upgrade doc like this. This should be pretty simple i.e. explaining customers to update version constraints, if they have any for TPG.

@imrannayer
Copy link
Collaborator

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 0024b24 into terraform-google-modules:master Aug 9, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Aug 9, 2023
Merged
This was referenced Aug 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaurabhuttam isaurabhuttam isaurabhuttam left review comments

@g-awmalik g-awmalik g-awmalik approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ibhaskar2 @imrannayer @g-awmalik @isaurabhuttam