Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TPG >= 4.80)!: add support for psc (private service connect) #507

Merged
merged 7 commits into from Sep 4, 2023
Merged

feat(TPG >= 4.80)!: add support for psc (private service connect) #507

merged 7 commits into from Sep 4, 2023

Conversation

imrannayer
Copy link
Collaborator

@imrannayer imrannayer commented Aug 29, 2023 •
edited

Fix #506
fix #483

@imrannayer imrannayer requested review from isaurabhuttam and a team as code owners August 29, 2023 15:15
@imrannayer imrannayer changed the title feat: add support for psc (private service connect) feat(TPG >= 4.80)!: add support for psc (private service connect) Aug 29, 2023
@g-awmalik
Copy link
Contributor

/gcbrun

bharathkkb
bharathkkb reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

modules/mysql/main.tf Outdated Show resolved Hide resolved
modules/postgresql/read_replica.tf Outdated Show resolved Hide resolved
test/integration/mysql-psc/mysql_psc_test.go Outdated Show resolved Hide resolved
@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

@imrannayer
Copy link
Collaborator Author

@bharathkkb can you plz merge this PR?

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 64c2435 into terraform-google-modules:master Sep 4, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Sep 3, 2023
Merged
@legal90 legal90 mentioned this pull request Oct 26, 2023
Merged
@imrannayer imrannayer self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaurabhuttam isaurabhuttam Awaiting requested review from isaurabhuttam isaurabhuttam is a code owner

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Private service connect Support separate insights_config for postgresql read replicas
3 participants
@imrannayer @g-awmalik @bharathkkb